From 28a98f57908d504abc8456e083624e467573aff3 Mon Sep 17 00:00:00 2001
From: "fefe.clochette" <ferlan.alexandre@gmail.com>
Date: Tue, 1 Sep 2026 16:18:14 +0200
Subject: [PATCH] fix delete category

---
 modules/budget/views/budget_prev.php    |  4 ++--
 modules/budget/views/settings_modal.php | 17 +++++++++++++----
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/modules/budget/views/budget_prev.php b/modules/budget/views/budget_prev.php
index 4fd7c37..7e9c0b0 100644
--- a/modules/budget/views/budget_prev.php
+++ b/modules/budget/views/budget_prev.php
@@ -306,7 +306,7 @@ if (count($parentMapping) >= 2) {
                                     data-transfer-dest="<?= htmlspecialchars($cat['transfer_dest'] ?? '') ?>" 
                                     data-holiday="<?= $cat['holiday_id'] ?? '' ?>" 
                                     onclick="openEditModal(this)">✎</button>
-                            <button type="button" onclick="deleteCategory(<?= $cat['id'] ?>)" class="btn-icon-action delete" title="<?= tr('delete') ?>">🗑️</button>
+                            <button type="button" onclick="deleteAllocCategory(<?= $cat['id'] ?>)" class="btn-icon-action delete" title="<?= tr('delete') ?>">🗑️</button>
                         </div>
                     </td>
                     <?php foreach ($months as $m): ?>
@@ -986,7 +986,7 @@ async function saveGenericNote(noteType, refId, content) {
     }
 }
 
-async function deleteCategory(id) {
+async function deleteAllocCategory(id) {
     if (!confirm(tr('bud_prev_confirm_del_line'))) return;
     const formData = new FormData();
     formData.append('action', 'delete_category');
diff --git a/modules/budget/views/settings_modal.php b/modules/budget/views/settings_modal.php
index d3c4ac4..c1d8491 100644
--- a/modules/budget/views/settings_modal.php
+++ b/modules/budget/views/settings_modal.php
@@ -324,7 +324,7 @@ function renderCategories(categories) {
                 <div class="pf-flex-gap-8">
                     <button type="button" class="btn-icon-action" onclick="moveCatUp(this)" title="Monter">⬆️</button>
                     <button type="button" class="btn-icon-action" onclick="moveCatDown(this)" title="Descendre">⬇️</button>
-                    <button type="button" class="btn-icon-action delete" onclick="deleteCategory(${cat.id})" title="${tr('btn_delete')}">🗑️</button>
+                    <button type="button" class="btn-icon-action delete" onclick="deleteBudgetCategory(${cat.id})" title="${tr('btn_delete')}">🗑️</button>
                 </div>
             </div>`;
     });
@@ -453,9 +453,18 @@ async function deleteAccount(id) { if (!await pachaConfirm(tr('btn_delete'), tr(
 const formAddAccount = document.getElementById('form-add-account');
 if (formAddAccount) formAddAccount.addEventListener('submit', async (e) => { e.preventDefault(); const btn = formAddAccount.querySelector('button'); const oldText = btn.innerText; btn.innerText = '⏳'; btn.disabled = true; try { const fd = new FormData(formAddAccount); fd.append('action', 'add_account'); await pachaFetch('/modules/budget/includes/api/settings.php', { method: 'POST', body: fd }); formAddAccount.reset(); await loadBudgetSettingsData(); } catch (err) { alert("Erreur : " + err.message); } finally { btn.innerText = oldText; btn.disabled = false; } });
 
-async function deleteCategory(id) { if (!await pachaConfirm(tr('btn_delete'), tr('bs_confirm_delete_cat'))) return; try { const fd = new FormData(); fd.append('action', 'delete_category'); fd.append('id', id); await pachaFetch('/modules/budget/includes/api/settings.php', { method: 'POST', body: fd }); await loadBudgetSettingsData(); } catch (err) { alert("Erreur : " + err.message); } }
-const formAddCategory = document.getElementById('form-add-category');
-if (formAddCategory) formAddCategory.addEventListener('submit', async (e) => { e.preventDefault(); const btn = formAddCategory.querySelector('button'); const oldText = btn.innerText; btn.innerText = '⏳'; btn.disabled = true; try { const fd = new FormData(formAddCategory); fd.append('action', 'add_category'); await pachaFetch('/modules/budget/includes/api/settings.php', { method: 'POST', body: fd }); formAddCategory.reset(); formAddCategory.querySelector('input[type="color"]').value = "#3b82f6"; await loadBudgetSettingsData(); } catch (err) { alert("Erreur : " + err.message); } finally { btn.innerText = oldText; btn.disabled = false; } });
+async function deleteBudgetCategory(id) { 
+    if (!await pachaConfirm(tr('btn_delete'), tr('bs_confirm_delete_cat'))) return; 
+    try { 
+        const fd = new FormData(); 
+        fd.append('action', 'delete_category'); 
+        fd.append('id', id); 
+        await pachaFetch('/modules/budget/includes/api/settings.php', { method: 'POST', body: fd }); 
+        await loadBudgetSettingsData(); 
+    } catch (err) { 
+        alert("Erreur : " + err.message); 
+    } 
+}
 
 function populateRuleCategories(categories) { const select = document.getElementById('select-rule-category'); if (!select) return; select.innerHTML = ''; if (!categories) return; categories.forEach(cat => { const opt = document.createElement('option'); opt.value = cat.code; opt.textContent = `${cat.icon || ''} ${cat.label}`; select.appendChild(opt); }); }
 async function deleteRule(id) { if (!await pachaConfirm(tr('btn_delete'), tr('bs_confirm_delete_rule'))) return; try { const fd = new FormData(); fd.append('action', 'delete_rule'); fd.append('id', id); await pachaFetch('/modules/budget/includes/api/settings.php', { method: 'POST', body: fd }); await loadBudgetSettingsData(); } catch (err) { alert("Erreur : " + err.message); } }